[clang] [clang][diagnostics] Update note_constexpr_invalid_cast to use enum_select and adjust its uses (PR #130868)

[Ayokunle Amodu via cfe-commits]

ayokunle321 wrote:

@erichkeane CI is happy now! For future patches, I was wondering if to separate them like this so reviews could be easier or I should just do it all in one PR.

https://github.com/llvm/llvm-project/pull/130868