[clang] [CIR] Upstream global initialization for ArrayType (PR #131657)

[Andy Kaylor via cfe-commits]

================
@@ -45,6 +45,41 @@ class CIRGenBuilderTy : public cir::CIRBaseBuilderTy {
     return false;
   }
 
+  // Return true if this is the null value
----------------
andykaylor wrote:

This isn't quite the comment I wanted to see. It doesn't tell me any more than the function name did. It needs to explain what "null value" means in the context of this function. Specifically, it doesn't mean "is equal to zero" because `-0.0` is equal to zero. Strings also get special handling, as will structures when they are implemented. Please describe the purpose of the function and highlight the special cases.

https://github.com/llvm/llvm-project/pull/131657