[clang] [clang] ASTContext: flesh out implementation of getCommonNNS (PR #131964)

Erich Keane via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 19 06:42:33 PDT 2025


================
@@ -13462,13 +13462,114 @@ static ElaboratedTypeKeyword getCommonTypeKeyword(const T *X, const T *Y) {
                                             : ElaboratedTypeKeyword::None;
 }
 
+static NestedNameSpecifier *getCommonNNS(ASTContext &Ctx,
+                                         NestedNameSpecifier *X,
----------------
erichkeane wrote:

X and Y are getting confusing as names when reviewing this :/  I know it isn't LHS and RHS, but even something that shows a bit more context (FirstNNS, SecondNNS, NNS1, NNS2, etc) would be helpful for reviewing/reading.

https://github.com/llvm/llvm-project/pull/131964


More information about the cfe-commits mailing list