[clang] [Format] Do not crash on non-null terminated strings (PR #131299)

Björn Schäpers via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 18 14:01:34 PDT 2025


================
@@ -2382,14 +2382,20 @@ size_t SourceManager::getDataStructureSizes() const {
 
 SourceManagerForFile::SourceManagerForFile(StringRef FileName,
                                            StringRef Content) {
+  // We copy to `std::string` for Context instead of StringRef because the
+  // SourceManager::getBufferData() works only with null-terminated buffers.
+  // And we still want to keep the API convenient.
+  ContentBuffer = Content.str();
----------------
HazardyKnusperkeks wrote:

I don't like it, but it's better than potentially crashing software.

But I'm not comfortable enough to approve something outside libFormat or clang-format.

https://github.com/llvm/llvm-project/pull/131299


More information about the cfe-commits mailing list