[clang] [NFC] Add a leading comment to boolean arguments. (PR #131746)
via cfe-commits
cfe-commits at lists.llvm.org
Tue Mar 18 00:28:28 PDT 2025
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-clang-modules
Author: Michael Park (mpark)
<details>
<summary>Changes</summary>
Addressing [nit comments](https://github.com/llvm/llvm-project/pull/129982#discussion_r1997914387) from @<!-- -->shafik
---
Full diff: https://github.com/llvm/llvm-project/pull/131746.diff
2 Files Affected:
- (modified) clang/lib/Serialization/ASTReader.cpp (+2-1)
- (modified) clang/lib/Serialization/ASTReaderDecl.cpp (+2-1)
``````````diff
diff --git a/clang/lib/Serialization/ASTReader.cpp b/clang/lib/Serialization/ASTReader.cpp
index 2c73501821bff..2b03446aaa30e 100644
--- a/clang/lib/Serialization/ASTReader.cpp
+++ b/clang/lib/Serialization/ASTReader.cpp
@@ -10825,7 +10825,8 @@ void ASTReader::FinishedDeserializing() {
{
// Guard variable to avoid recursively entering the process of passing
// decls to consumer.
- SaveAndRestore GuardPassingDeclsToConsumer(CanPassDeclsToConsumer, false);
+ SaveAndRestore GuardPassingDeclsToConsumer(CanPassDeclsToConsumer,
+ /*NewValue=*/false);
// Propagate exception specification and deduced type updates along
// redeclaration chains.
diff --git a/clang/lib/Serialization/ASTReaderDecl.cpp b/clang/lib/Serialization/ASTReaderDecl.cpp
index 79bd41aa2644e..c3341e00bacef 100644
--- a/clang/lib/Serialization/ASTReaderDecl.cpp
+++ b/clang/lib/Serialization/ASTReaderDecl.cpp
@@ -4314,7 +4314,8 @@ void ASTReader::PassInterestingDeclsToConsumer() {
// Guard variable to avoid recursively redoing the process of passing
// decls to consumer.
- SaveAndRestore GuardPassingDeclsToConsumer(CanPassDeclsToConsumer, false);
+ SaveAndRestore GuardPassingDeclsToConsumer(CanPassDeclsToConsumer,
+ /*NewValue=*/false);
// Ensure that we've loaded all potentially-interesting declarations
// that need to be eagerly loaded.
``````````
</details>
https://github.com/llvm/llvm-project/pull/131746
More information about the cfe-commits
mailing list