[clang] [MS][clang] Add support for vector deleting destructors (PR #126240)

[Hans Wennborg via cfe-commits]

zmodem wrote:

> but, that is still not a great reproducer for a reverted patch. Especially if the link issue is due to a missing support in linker. I would appreciate if you could maybe point to how exactly UnicodeString is used in failing scenario.

I'm sorry that we didn't catch this problem sooner and were able to provide better reproducers.

I still think reverting was right though. There is clearly a subtle problem here -- both at link time and run time -- and the fewer people who run into that the better. Even if it turns out that the root cause lies in lld.

I've uploaded a stand-alone from-source reproducer of the run time crash here: https://crbug.com/402425841#comment10

https://github.com/llvm/llvm-project/pull/126240