[clang] 4acfeaf - [Tooling] Avoid repeated hash lookups (NFC) (#131264)
via cfe-commits
cfe-commits at lists.llvm.org
Fri Mar 14 07:20:57 PDT 2025
Author: Kazu Hirata
Date: 2025-03-14T07:20:54-07:00
New Revision: 4acfeafd8fa46f22e449b24a49c128a312f900fb
URL: https://github.com/llvm/llvm-project/commit/4acfeafd8fa46f22e449b24a49c128a312f900fb
DIFF: https://github.com/llvm/llvm-project/commit/4acfeafd8fa46f22e449b24a49c128a312f900fb.diff
LOG: [Tooling] Avoid repeated hash lookups (NFC) (#131264)
Added:
Modified:
clang/lib/Tooling/RefactoringCallbacks.cpp
Removed:
################################################################################
diff --git a/clang/lib/Tooling/RefactoringCallbacks.cpp b/clang/lib/Tooling/RefactoringCallbacks.cpp
index e3fc91afeb595..80e78e27434cc 100644
--- a/clang/lib/Tooling/RefactoringCallbacks.cpp
+++ b/clang/lib/Tooling/RefactoringCallbacks.cpp
@@ -220,13 +220,14 @@ void ReplaceNodeWithTemplate::run(
}
}
}
- if (NodeMap.count(FromId) == 0) {
+ auto It = NodeMap.find(FromId);
+ if (It == NodeMap.end()) {
llvm::errs() << "Node to be replaced " << FromId
<< " not bound in query.\n";
llvm::report_fatal_error("FromId node not bound in MatchResult");
}
auto Replacement =
- tooling::Replacement(*Result.SourceManager, &NodeMap.at(FromId), ToText,
+ tooling::Replacement(*Result.SourceManager, &It->second, ToText,
Result.Context->getLangOpts());
llvm::Error Err = Replace.add(Replacement);
if (Err) {
More information about the cfe-commits
mailing list