[clang] [clang] Remove usage of llvm-spirv in clang LIT tests (PR #131158)

Nick Sarnie via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 13 08:33:06 PDT 2025


https://github.com/sarnex created https://github.com/llvm/llvm-project/pull/131158

We use the backend now, so remove the requirement from the only test that actually executes it and remove the LIT requirement variable.

>From 196e880b258e48c18ec0f6a88a11eb8149d3b16b Mon Sep 17 00:00:00 2001
From: "Sarnie, Nick" <nick.sarnie at intel.com>
Date: Thu, 13 Mar 2025 08:31:46 -0700
Subject: [PATCH] [clang] Remove usage of llvm-spirv in clang LIT tests

Signed-off-by: Sarnie, Nick <nick.sarnie at intel.com>
---
 clang/test/Tooling/clang-linker-wrapper-spirv-elf.cpp | 2 +-
 clang/test/Tooling/lit.local.cfg                      | 3 ---
 2 files changed, 1 insertion(+), 4 deletions(-)

diff --git a/clang/test/Tooling/clang-linker-wrapper-spirv-elf.cpp b/clang/test/Tooling/clang-linker-wrapper-spirv-elf.cpp
index 9b16727d74192..af98904677283 100644
--- a/clang/test/Tooling/clang-linker-wrapper-spirv-elf.cpp
+++ b/clang/test/Tooling/clang-linker-wrapper-spirv-elf.cpp
@@ -1,7 +1,7 @@
 // Verify the ELF packaging of OpenMP SPIR-V device images.
 // REQUIRES: system-linux
 // REQUIRES: spirv-tools
-// REQUIRES: llvm-spirv
+// REQUIRES: spirv-registered-target
 // RUN: mkdir -p %t_tmp
 // RUN: cd %t_tmp
 // RUN: %clangxx -fopenmp -fopenmp-targets=spirv64-intel -nogpulib -c -o %t_clang-linker-wrapper-spirv-elf.o %s
diff --git a/clang/test/Tooling/lit.local.cfg b/clang/test/Tooling/lit.local.cfg
index 61f328c91e4d3..46d32e6ebf454 100644
--- a/clang/test/Tooling/lit.local.cfg
+++ b/clang/test/Tooling/lit.local.cfg
@@ -9,6 +9,3 @@ if config.spirv_tools_tests:
     config.substitutions.append(("spirv-val", os.path.join(config.llvm_tools_dir, "spirv-val")))
     config.substitutions.append(("spirv-as", os.path.join(config.llvm_tools_dir, "spirv-as")))
     config.substitutions.append(("spirv-link", os.path.join(config.llvm_tools_dir, "spirv-link")))
-
-if lit.util.which("llvm-spirv"):
-    config.available_features.add("llvm-spirv")



More information about the cfe-commits mailing list