[clang] [MS][clang] Add support for vector deleting destructors (PR #126240)
Aaron Ballman via cfe-commits
cfe-commits at lists.llvm.org
Thu Mar 13 04:55:13 PDT 2025
AaronBallman wrote:
> We're hitting link errors after this change when building with sanitizer coverage enabled:
>
> ```
> lld-link: error: relocation against symbol in discarded section: .text
> >>> referenced by obj/third_party/icu/icuuc_private/filteredbrk.obj:(.SCOVP$M)
> >>> referenced by obj/third_party/icu/icuuc_private/filteredbrk.obj:(.SCOVP$M)
> >>> referenced by obj/third_party/icu/icuuc_private/filteredbrk.obj:(.SCOVP$M)
> >>> referenced by obj/third_party/icu/icuuc_private/filteredbrk.obj:(.SCOVP$M)
> >>> referenced by obj/third_party/icu/icuuc_private/filteredbrk.obj:(.SCOVP$M)
> ```
>
> I've added preprocessed source and compiler invocation for filteredbrk.obj here: https://crbug.com/402354446#comment6 Can you take a look?
>
> I'll revert this to unbreak things in the meantime.
@zmodem can you prioritize helping to get a reproducer that @Fznamznon can work with? This is blocking important work and the revert was very quick given that the patch had already been in tree for over a week. Our revert policy doesn't define what a timely revert is, but the usual expectation when a bot is not broken is that you alert the author, if they're quickly responsive then you work with them before doing a revert to reduce the amount of disruption to the LLVM community.
https://github.com/llvm/llvm-project/pull/126240
More information about the cfe-commits
mailing list