[clang] [Sema] Avoid repeated hash lookups (NFC) (PR #131065)

Kazu Hirata via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 12 20:54:14 PDT 2025


https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/131065

None

>From fa3d28370a754d75ef18c419c2fd66185e5f1302 Mon Sep 17 00:00:00 2001
From: Kazu Hirata <kazu at google.com>
Date: Wed, 12 Mar 2025 08:55:12 -0700
Subject: [PATCH] [Sema] Avoid repeated hash lookups (NFC)

---
 clang/lib/Sema/SemaOpenACCClause.cpp | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/clang/lib/Sema/SemaOpenACCClause.cpp b/clang/lib/Sema/SemaOpenACCClause.cpp
index ad54e2bbe9495..33c2d5d6c8c4c 100644
--- a/clang/lib/Sema/SemaOpenACCClause.cpp
+++ b/clang/lib/Sema/SemaOpenACCClause.cpp
@@ -2468,14 +2468,14 @@ bool SemaOpenACC::CheckDeclareClause(SemaOpenACC::OpenACCParsedClause &Clause) {
       // directives for a function, subroutine, program, or module.
 
       if (CurDecl) {
-        auto Itr = DeclareVarReferences.find(CurDecl);
-        if (Itr != DeclareVarReferences.end()) {
+        auto [Itr, Inserted] = DeclareVarReferences.try_emplace(CurDecl);
+        if (!Inserted) {
           Diag(VarExpr->getBeginLoc(), diag::err_acc_multiple_references)
               << Clause.getClauseKind();
           Diag(Itr->second, diag::note_acc_previous_reference);
           continue;
         } else {
-          DeclareVarReferences[CurDecl] = VarExpr->getBeginLoc();
+          Itr->second = VarExpr->getBeginLoc();
         }
       }
     }



More information about the cfe-commits mailing list