[clang] [Clang][WIP] Constant Expressions inside of gcc'asm strings (PR #131003)

Erich Keane via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 12 11:43:53 PDT 2025


================
@@ -328,20 +328,20 @@ void StmtProfiler::VisitGCCAsmStmt(const GCCAsmStmt *S) {
   VisitStmt(S);
   ID.AddBoolean(S->isVolatile());
   ID.AddBoolean(S->isSimple());
-  VisitStringLiteral(S->getAsmString());
+  VisitExpr(S->getAsmStringExpr());
----------------
erichkeane wrote:

Are these necessary? I would expect the `children` definition of the statement should instead print these.  It'll change how the ast-dump works, but for the better IMO.  Though perhaps we like how these look...

https://github.com/llvm/llvm-project/pull/131003


More information about the cfe-commits mailing list