[clang] 5c02e74 - Fix use of CXXThisScopeRAII

via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 12 08:19:26 PDT 2025


Author: erichkeane
Date: 2025-03-12T08:19:21-07:00
New Revision: 5c02e74d21fdec44fa9c3a8b45ef60e5b433bf71

URL: https://github.com/llvm/llvm-project/commit/5c02e74d21fdec44fa9c3a8b45ef60e5b433bf71
DIFF: https://github.com/llvm/llvm-project/commit/5c02e74d21fdec44fa9c3a8b45ef60e5b433bf71.diff

LOG: Fix use of CXXThisScopeRAII

Seemingly I managed to not give this a name, and not notice that it
didn't properly introduce the scope it was supposed to!  This patch
gives it a name which should hopefully/presumably fix any cases where we
don't properly introduce the 'this' scope.  I presume that previous
callers to this might also do this in most cases so that this is a
redundant scope, but we have to make sure it happens.

FIXES: #130846

Added: 
    

Modified: 
    clang/lib/Sema/SemaTemplate.cpp

Removed: 
    


################################################################################
diff  --git a/clang/lib/Sema/SemaTemplate.cpp b/clang/lib/Sema/SemaTemplate.cpp
index 64aabb1fcdc35..a56720ec26fbd 100644
--- a/clang/lib/Sema/SemaTemplate.cpp
+++ b/clang/lib/Sema/SemaTemplate.cpp
@@ -5845,7 +5845,7 @@ bool Sema::CheckTemplateArgumentList(
       ThisQuals = Method->getMethodQualifiers();
 
     ContextRAII Context(*this, NewContext);
-    CXXThisScopeRAII(*this, RD, ThisQuals, RD != nullptr);
+    CXXThisScopeRAII Scope(*this, RD, ThisQuals, RD != nullptr);
 
     MultiLevelTemplateArgumentList MLTAL = getTemplateInstantiationArgs(
         Template, NewContext, /*Final=*/false, CTAI.CanonicalConverted,


        


More information about the cfe-commits mailing list