[clang] [llvm] [ARM][Clang] Make `+nosimd` functional for AArch32 Targets (PR #130623)

[Jack Styles via cfe-commits]

================
@@ -334,8 +334,8 @@ ARM_CPU_NAME("cortex-r7", ARMV7R, FK_VFPV3_D16_FP16, false,
              (ARM::AEK_MP | ARM::AEK_HWDIVARM))
 ARM_CPU_NAME("cortex-r8", ARMV7R, FK_VFPV3_D16_FP16, false,
              (ARM::AEK_MP | ARM::AEK_HWDIVARM))
-ARM_CPU_NAME("cortex-r52", ARMV8R, FK_NEON_FP_ARMV8, false, ARM::AEK_NONE)
-ARM_CPU_NAME("cortex-r52plus", ARMV8R, FK_NEON_FP_ARMV8, false, ARM::AEK_NONE)
+ARM_CPU_NAME("cortex-r52", ARMV8R, FK_NEON_FP_ARMV8, false, ARM::AEK_SIMD)
+ARM_CPU_NAME("cortex-r52plus", ARMV8R, FK_NEON_FP_ARMV8, false, ARM::AEK_SIMD)
----------------
Stylie777 wrote:

I am posing this a question rather than a statement as I am not sure of the answer, but could LLVM be taking the target features defined as a `-target-feature` option over the features that come from the fpu? Reason I ask is before this change, `-target-feature +neon` never appeared for targets when I added `-###` to the command, but now they are. If neon is not defined for that target, it passes `-target-feature -neon` because the ID of `ARM::AEK_SIMD` is not included in the features from the `ARMTargetFeatures.def` file. 

That could explain why we need this change.

https://github.com/llvm/llvm-project/pull/130623