[clang] [alpha.webkit.UnretainedCallArgsChecker] Add a checker for NS or CF type call arguments. (PR #130729)

Tue Mar 11 13:07:00 PDT 2025

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `arc-builder` running on `arc-worker` while building `clang` at step 6 "test-build-unified-tree-check-all".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/3/builds/12949

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 6 (test-build-unified-tree-check-all) failure: test (failure)
******************** TEST 'Clang :: Analysis/Checkers/WebKit/unretained-call-args.mm' FAILED ********************
Exit Code: 134

Command Output (stderr):
--
RUN: at line 1: /buildbot/worker/arc-folder/build/bin/clang -cc1 -internal-isystem /buildbot/worker/arc-folder/build/lib/clang/21/include -nostdsysteminc -analyze -analyzer-constraints=range -setup-static-analyzer -analyzer-checker=alpha.webkit.UnretainedCallArgsChecker -verify /buildbot/worker/arc-folder/llvm-project/clang/test/Analysis/Checkers/WebKit/unretained-call-args.mm
+ /buildbot/worker/arc-folder/build/bin/clang -cc1 -internal-isystem /buildbot/worker/arc-folder/build/lib/clang/21/include -nostdsysteminc -analyze -analyzer-constraints=range -setup-static-analyzer -analyzer-checker=alpha.webkit.UnretainedCallArgsChecker -verify /buildbot/worker/arc-folder/llvm-project/clang/test/Analysis/Checkers/WebKit/unretained-call-args.mm
clang: /buildbot/worker/arc-folder/llvm-project/llvm/include/llvm/Support/Casting.h:662: decltype(auto) llvm::dyn_cast(From*) [with To = clang::ParenExpr; From = clang::Expr]: Assertion `detail::isPresent(Val) && "dyn_cast on a non-existent value"' failed.
PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace, preprocessed source, and associated run script.
Stack dump:
0.	Program arguments: /buildbot/worker/arc-folder/build/bin/clang -cc1 -internal-isystem /buildbot/worker/arc-folder/build/lib/clang/21/include -nostdsysteminc -analyze -analyzer-constraints=range -setup-static-analyzer -analyzer-checker=alpha.webkit.UnretainedCallArgsChecker -verify /buildbot/worker/arc-folder/llvm-project/clang/test/Analysis/Checkers/WebKit/unretained-call-args.mm
1.	<eof> parser at end of file
 #0 0x00000000020ace48 llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) (/buildbot/worker/arc-folder/build/bin/clang+0x20ace48)
 #1 0x00000000020aa1e5 SignalHandler(int, siginfo_t*, void*) Signals.cpp:0:0
 #2 0x00007f4660c08630 __restore_rt sigaction.c:0:0
 #3 0x00007f465f9583d7 raise (/usr/lib64/libc.so.6+0x363d7)
 #4 0x00007f465f959ac8 abort (/usr/lib64/libc.so.6+0x37ac8)
 #5 0x00007f465f9511a6 __assert_fail_base (/usr/lib64/libc.so.6+0x2f1a6)
 #6 0x00007f465f951252 (/usr/lib64/libc.so.6+0x2f252)
 #7 0x0000000004a88eb4 (/buildbot/worker/arc-folder/build/bin/clang+0x4a88eb4)
 #8 0x00000000055b39b0 clang::Expr::IgnoreParenCasts() (/buildbot/worker/arc-folder/build/bin/clang+0x55b39b0)
 #9 0x00000000041c79d4 (anonymous namespace)::RawPtrRefCallArgsChecker::checkASTDecl(clang::TranslationUnitDecl const*, clang::ento::AnalysisManager&, clang::ento::BugReporter&) const::LocalVisitor::VisitObjCMessageExpr(clang::ObjCMessageExpr*) RawPtrRefCallArgsChecker.cpp:0:0
#10 0x00000000054e90f5 clang::DynamicRecursiveASTVisitorBase<false>::TraverseObjCMessageExpr(clang::ObjCMessageExpr*) (/buildbot/worker/arc-folder/build/bin/clang+0x54e90f5)
#11 0x00000000054daac1 clang::RecursiveASTVisitor<(anonymous namespace)::Impl<false>>::TraverseStmt(clang::Stmt*, llvm::SmallVectorImpl<llvm::PointerIntPair<clang::Stmt*, 1u, bool, llvm::PointerLikeTypeTraits<clang::Stmt*>, llvm::PointerIntPairInfo<clang::Stmt*, 1u, llvm::PointerLikeTypeTraits<clang::Stmt*>>>>*) (.constprop.0) DynamicRecursiveASTVisitor.cpp:0:0
#12 0x00000000054dabf3 clang::DynamicRecursiveASTVisitorBase<false>::TraverseStmt(clang::Stmt*) (/buildbot/worker/arc-folder/build/bin/clang+0x54dabf3)
#13 0x00000000054e9062 clang::DynamicRecursiveASTVisitorBase<false>::TraverseObjCMessageExpr(clang::ObjCMessageExpr*) (/buildbot/worker/arc-folder/build/bin/clang+0x54e9062)
#14 0x00000000054daac1 clang::RecursiveASTVisitor<(anonymous namespace)::Impl<false>>::TraverseStmt(clang::Stmt*, llvm::SmallVectorImpl<llvm::PointerIntPair<clang::Stmt*, 1u, bool, llvm::PointerLikeTypeTraits<clang::Stmt*>, llvm::PointerIntPairInfo<clang::Stmt*, 1u, llvm::PointerLikeTypeTraits<clang::Stmt*>>>>*) (.constprop.0) DynamicRecursiveASTVisitor.cpp:0:0
#15 0x00000000054dabf3 clang::DynamicRecursiveASTVisitorBase<false>::TraverseStmt(clang::Stmt*) (/buildbot/worker/arc-folder/build/bin/clang+0x54dabf3)
#16 0x0000000005503102 clang::DynamicRecursiveASTVisitorBase<false>::TraverseCallExpr(clang::CallExpr*) (/buildbot/worker/arc-folder/build/bin/clang+0x5503102)
#17 0x00000000054daac1 clang::RecursiveASTVisitor<(anonymous namespace)::Impl<false>>::TraverseStmt(clang::Stmt*, llvm::SmallVectorImpl<llvm::PointerIntPair<clang::Stmt*, 1u, bool, llvm::PointerLikeTypeTraits<clang::Stmt*>, llvm::PointerIntPairInfo<clang::Stmt*, 1u, llvm::PointerLikeTypeTraits<clang::Stmt*>>>>*) (.constprop.0) DynamicRecursiveASTVisitor.cpp:0:0
#18 0x00000000054dabf3 clang::DynamicRecursiveASTVisitorBase<false>::TraverseStmt(clang::Stmt*) (/buildbot/worker/arc-folder/build/bin/clang+0x54dabf3)
#19 0x0000000005508202 clang::DynamicRecursiveASTVisitorBase<false>::TraverseCXXBindTemporaryExpr(clang::CXXBindTemporaryExpr*) (/buildbot/worker/arc-folder/build/bin/clang+0x5508202)
#20 0x00000000054daac1 clang::RecursiveASTVisitor<(anonymous namespace)::Impl<false>>::TraverseStmt(clang::Stmt*, llvm::SmallVectorImpl<llvm::PointerIntPair<clang::Stmt*, 1u, bool, llvm::PointerLikeTypeTraits<clang::Stmt*>, llvm::PointerIntPairInfo<clang::Stmt*, 1u, llvm::PointerLikeTypeTraits<clang::Stmt*>>>>*) (.constprop.0) DynamicRecursiveASTVisitor.cpp:0:0
#21 0x00000000054dabf3 clang::DynamicRecursiveASTVisitorBase<false>::TraverseStmt(clang::Stmt*) (/buildbot/worker/arc-folder/build/bin/clang+0x54dabf3)
#22 0x000000000550e7a6 clang::DynamicRecursiveASTVisitorBase<false>::TraverseExprWithCleanups(clang::ExprWithCleanups*) (/buildbot/worker/arc-folder/build/bin/clang+0x550e7a6)
#23 0x00000000054daac1 clang::RecursiveASTVisitor<(anonymous namespace)::Impl<false>>::TraverseStmt(clang::Stmt*, llvm::SmallVectorImpl<llvm::PointerIntPair<clang::Stmt*, 1u, bool, llvm::PointerLikeTypeTraits<clang::Stmt*>, llvm::PointerIntPairInfo<clang::Stmt*, 1u, llvm::PointerLikeTypeTraits<clang::Stmt*>>>>*) (.constprop.0) DynamicRecursiveASTVisitor.cpp:0:0
#24 0x00000000054dabf3 clang::DynamicRecursiveASTVisitorBase<false>::TraverseStmt(clang::Stmt*) (/buildbot/worker/arc-folder/build/bin/clang+0x54dabf3)
#25 0x00000000055136b9 clang::DynamicRecursiveASTVisitorBase<false>::TraverseVarDecl(clang::VarDecl*) (/buildbot/worker/arc-folder/build/bin/clang+0x55136b9)
#26 0x00000000041c2f27 (anonymous namespace)::RawPtrRefCallArgsChecker::checkASTDecl(clang::TranslationUnitDecl const*, clang::ento::AnalysisManager&, clang::ento::BugReporter&) const::LocalVisitor::TraverseDecl(clang::Decl*) RawPtrRefCallArgsChecker.cpp:0:0
#27 0x00000000054da816 clang::DynamicRecursiveASTVisitorBase<false>::TraverseDeclStmt(clang::DeclStmt*) (/buildbot/worker/arc-folder/build/bin/clang+0x54da816)
#28 0x00000000054daac1 clang::RecursiveASTVisitor<(anonymous namespace)::Impl<false>>::TraverseStmt(clang::Stmt*, llvm::SmallVectorImpl<llvm::PointerIntPair<clang::Stmt*, 1u, bool, llvm::PointerLikeTypeTraits<clang::Stmt*>, llvm::PointerIntPairInfo<clang::Stmt*, 1u, llvm::PointerLikeTypeTraits<clang::Stmt*>>>>*) (.constprop.0) DynamicRecursiveASTVisitor.cpp:0:0
#29 0x00000000054dabf3 clang::DynamicRecursiveASTVisitorBase<false>::TraverseStmt(clang::Stmt*) (/buildbot/worker/arc-folder/build/bin/clang+0x54dabf3)
#30 0x00000000054e844a clang::DynamicRecursiveASTVisitorBase<false>::TraverseCompoundStmt(clang::CompoundStmt*) (/buildbot/worker/arc-folder/build/bin/clang+0x54e844a)
#31 0x00000000054daac1 clang::RecursiveASTVisitor<(anonymous namespace)::Impl<false>>::TraverseStmt(clang::Stmt*, llvm::SmallVectorImpl<llvm::PointerIntPair<clang::Stmt*, 1u, bool, llvm::PointerLikeTypeTraits<clang::Stmt*>, llvm::PointerIntPairInfo<clang::Stmt*, 1u, llvm::PointerLikeTypeTraits<clang::Stmt*>>>>*) (.constprop.0) DynamicRecursiveASTVisitor.cpp:0:0
#32 0x00000000054dabf3 clang::DynamicRecursiveASTVisitorBase<false>::TraverseStmt(clang::Stmt*) (/buildbot/worker/arc-folder/build/bin/clang+0x54dabf3)
#33 0x000000000551fb55 clang::RecursiveASTVisitor<(anonymous namespace)::Impl<false>>::TraverseFunctionHelper(clang::FunctionDecl*) DynamicRecursiveASTVisitor.cpp:0:0
#34 0x000000000551fdf0 clang::DynamicRecursiveASTVisitorBase<false>::TraverseFunctionDecl(clang::FunctionDecl*) (/buildbot/worker/arc-folder/build/bin/clang+0x551fdf0)
#35 0x00000000041c2f27 (anonymous namespace)::RawPtrRefCallArgsChecker::checkASTDecl(clang::TranslationUnitDecl const*, clang::ento::AnalysisManager&, clang::ento::BugReporter&) const::LocalVisitor::TraverseDecl(clang::Decl*) RawPtrRefCallArgsChecker.cpp:0:0
#36 0x00000000054e220c clang::RecursiveASTVisitor<(anonymous namespace)::Impl<false>>::TraverseDeclContextHelper(clang::DeclContext*) (.part.0) DynamicRecursiveASTVisitor.cpp:0:0
#37 0x0000000005512b46 clang::DynamicRecursiveASTVisitorBase<false>::TraverseNamespaceDecl(clang::NamespaceDecl*) (/buildbot/worker/arc-folder/build/bin/clang+0x5512b46)
...

```

</details>

https://github.com/llvm/llvm-project/pull/130729