[clang] [HLSL] Add bounds checks for the hlsl vector arguments and return types (PR #130724)
Sarah Spall via cfe-commits
cfe-commits at lists.llvm.org
Tue Mar 11 09:25:56 PDT 2025
https://github.com/spall commented:
Looks mostly good to me, a couple of questions though which applied to most of the templates in the code, but I only commented on the first instances I saw.
1. Do you need to check T is arithmetic if you're also checking its half? Wont' the half check suffice?
2. capitalize value here? I assume this didn't cause you an error but nice to be consistent with use of Caps
https://github.com/llvm/llvm-project/pull/130724
More information about the cfe-commits
mailing list