[clang] [clang-tools-extra] [clang] improve class type sugar preservation in pointers to members (PR #130537)

Erich Keane via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 10 09:25:05 PDT 2025


================
@@ -13461,13 +13486,112 @@ static ElaboratedTypeKeyword getCommonTypeKeyword(const T *X, const T *Y) {
                                             : ElaboratedTypeKeyword::None;
 }
 
+static NestedNameSpecifier *getCommonNNS(ASTContext &Ctx,
+                                         NestedNameSpecifier *X,
+                                         NestedNameSpecifier *Y, bool Sugar) {
----------------
erichkeane wrote:

I still think X and Y need better names, but could be talked out of it as convention (I see we're using it elsewhere here), but `Sugar` needs to find a better name.  Your description of its meaning doesn't show that implication at all.

https://github.com/llvm/llvm-project/pull/130537


More information about the cfe-commits mailing list