[clang] Better diagnostics when assertion fails in `consteval` (PR #130458)

[via cfe-commits]

================
@@ -8361,6 +8361,17 @@ class ExprEvaluatorBase
         return false;
     }
 
+    // If an assertion fails during constant evaluation, give a specific note explaining that
+    if (FD->getName() == "__assert_fail") {
----------------
cor3ntin wrote:

Maybe we can instead check if
 - `PP.getImmediateMacroName(E->getBeginLoc())` is a macro call assert
 - `FD->getName()` contains the string "assert"

It might be less brittle

https://github.com/llvm/llvm-project/pull/130458