[clang] [CIR] Upstream basic support for ArrayType (PR #130502)
Erich Keane via cfe-commits
cfe-commits at lists.llvm.org
Mon Mar 10 07:31:13 PDT 2025
================
@@ -33,6 +33,14 @@ class CIRGenBuilderTy : public cir::CIRBaseBuilderTy {
llvm_unreachable("NYI: PPC double-double format for long double");
llvm_unreachable("Unsupported format for long double");
}
+
+ bool isSized(mlir::Type ty) {
+ if (mlir::isa<cir::PointerType, cir::ArrayType, cir::BoolType,
+ cir::IntType>(ty))
+ return true;
+ assert(0 && "Unimplemented size for type");
----------------
erichkeane wrote:
looks like we've been doing `llvm_unreachable` for not yet implemented. That said, its pretty weird that asking this question (`isSized`) is a not-implemented? What sort of stuff is missing here that we cannot just answer this question?
https://github.com/llvm/llvm-project/pull/130502
More information about the cfe-commits
mailing list