[clang] C89 doesn't have `math.h` functions (PR #129979)
via cfe-commits
cfe-commits at lists.llvm.org
Sun Mar 9 11:18:36 PDT 2025
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff 91aac7c379fb92348593d51e3f2d9e490ff67526 160d719b7ed5997d39accb110df873e6200991d4 --extensions cpp,c -- clang/test/C/drs/c89_with_c99_functions.c clang/lib/Basic/Builtins.cpp
``````````
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/clang/lib/Basic/Builtins.cpp b/clang/lib/Basic/Builtins.cpp
index 70ea34da1f..4795a7fca6 100644
--- a/clang/lib/Basic/Builtins.cpp
+++ b/clang/lib/Basic/Builtins.cpp
@@ -137,12 +137,13 @@ bool Builtin::Context::isBuiltinFunc(llvm::StringRef FuncName) {
return false;
}
-static bool isSymbolAvailableInC89(const llvm::StringTable& Strings, const Builtin::Info & BuiltinInfo) {
+static bool isSymbolAvailableInC89(const llvm::StringTable &Strings,
+ const Builtin::Info &BuiltinInfo) {
auto NameStr = Strings[BuiltinInfo.Offsets.Name];
// FIXME: add other C89 symbols here
- if(NameStr == "log") {
+ if (NameStr == "log") {
return true;
}
@@ -166,8 +167,7 @@ static bool builtinIsSupported(const llvm::StringTable &Strings,
return false;
}
/* MathBuiltins Unsupported */
- if (LangOpts.NoMathBuiltin &&
- BuiltinInfo.Header.ID == HeaderDesc::MATH_H)
+ if (LangOpts.NoMathBuiltin && BuiltinInfo.Header.ID == HeaderDesc::MATH_H)
return false;
/* GnuMode Unsupported */
if (!LangOpts.GNUMode && (BuiltinInfo.Langs & GNU_LANG))
``````````
</details>
https://github.com/llvm/llvm-project/pull/129979
More information about the cfe-commits
mailing list