[clang] [clang] Remove isOSWindows() checks (PR #129909)

Martin Storsjö via cfe-commits cfe-commits at lists.llvm.org
Fri Mar 7 05:49:54 PST 2025


================
@@ -4769,31 +4769,32 @@ ExprResult Sema::CheckOSLogFormatStringArg(Expr *Arg) {
 /// Check that the user is calling the appropriate va_start builtin for the
 /// target and calling convention.
 static bool checkVAStartABI(Sema &S, unsigned BuiltinID, Expr *Fn) {
-  const llvm::Triple &TT = S.Context.getTargetInfo().getTriple();
+  const TargetInfo &TI = S.Context.getTargetInfo();
+  bool IsMicrosoftABI = TI.getCXXABI().isMicrosoft();
----------------
mstorsjo wrote:

Indeed - mingw is Windows but does not use the Microsoft C++ ABI. It does use the Microsoft C ABI though, mostly.

https://github.com/llvm/llvm-project/pull/129909


More information about the cfe-commits mailing list