[clang] [HLSL] make semantic matching case insensitive (PR #129773)

Chris B via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 6 13:04:44 PST 2025


================
@@ -141,6 +141,8 @@ void Parser::ParseHLSLAnnotations(ParsedAttributes &Attrs,
     return;
   }
 
+  II = PP.getIdentifierInfo(II->getName().lower());
----------------
llvm-beanz wrote:

Can we keep the original identifier around and use that for the diagnostics so that the diagnostic text matches the capitalization in the source?

I often find myself copy and pasting error message text to then grep codebases, so it would be nice if we preserved the spelling.

https://github.com/llvm/llvm-project/pull/129773


More information about the cfe-commits mailing list