[clang] [C++20][Modules] Fix incomplete decl chains (PR #129982)

[Chuanqi Xu via cfe-commits]

================
@@ -9180,6 +9180,12 @@ bool Sema::hasAcceptableDefinition(NamedDecl *D, NamedDecl **Suggested,
   if (!getLangOpts().Modules && !getLangOpts().ModulesLocalVisibility)
     return true;
 
+  // The external source may have additional definitions of this entity that are
+  // visible, so complete the redeclaration chain now.
+  if (auto *Source = Context.getExternalSource()) {
+    Source->CompleteRedeclChain(D);
+  }
----------------
ChuanqiXu9 wrote:

Thanks for the analysis. It looks like the root cause was the DefinitionData for [4] **was** not updated correctly. So DefinitionData->Definition is a nullptr.

https://github.com/llvm/llvm-project/pull/129982