[clang] [C++20][Modules] Fix incomplete decl chains (PR #129982)

Chuanqi Xu via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 5 21:22:20 PST 2025


================
@@ -9180,6 +9180,12 @@ bool Sema::hasAcceptableDefinition(NamedDecl *D, NamedDecl **Suggested,
   if (!getLangOpts().Modules && !getLangOpts().ModulesLocalVisibility)
     return true;
 
+  // The external source may have additional definitions of this entity that are
+  // visible, so complete the redeclaration chain now.
+  if (auto *Source = Context.getExternalSource()) {
+    Source->CompleteRedeclChain(D);
+  }
----------------
ChuanqiXu9 wrote:

To be honest, the completing redecl chain logic is more or less is in a mess. But let's try to do make things better if possible. I feel better to do this in redecls.


https://github.com/llvm/llvm-project/pull/129982


More information about the cfe-commits mailing list