[clang] [NFC][c-index-test] factor data len out (PR #129971)
via cfe-commits
cfe-commits at lists.llvm.org
Wed Mar 5 17:55:46 PST 2025
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-clang
Author: Jinsong Ji (jsji)
<details>
<summary>Changes</summary>
---
Full diff: https://github.com/llvm/llvm-project/pull/129971.diff
1 Files Affected:
- (modified) clang/tools/c-index-test/c-index-test.c (+3-5)
``````````diff
diff --git a/clang/tools/c-index-test/c-index-test.c b/clang/tools/c-index-test/c-index-test.c
index 50f32c0a20e5a..1ad2e44aae3f7 100644
--- a/clang/tools/c-index-test/c-index-test.c
+++ b/clang/tools/c-index-test/c-index-test.c
@@ -3554,13 +3554,11 @@ static CXIdxClientContainer makeClientContainer(CXClientData *client_data,
clang_indexLoc_getFileLocation(loc, &file, 0, &line, &column, 0);
- len = sizeof(IndexDataStringList) + strlen(name) + digitCount(line) +
- digitCount(column) + 3;
- node = (IndexDataStringList *)malloc(len);
+ datalen = strlen(name) + digitCount(line) + digitCount(column) + 3;
+ node = (IndexDataStringList *)malloc(len + sizeof(IndexDataStringList));
assert(node);
newStr = node->data;
- snprintf(newStr, len - sizeof(IndexDataStringList), "%s:%d:%d", name, line,
- column);
+ snprintf(newStr, datalen, "%s:%d:%d", name, line, column);
/* Remember string so it can be freed later. */
index_data = (IndexData *)client_data;
``````````
</details>
https://github.com/llvm/llvm-project/pull/129971
More information about the cfe-commits
mailing list