[clang] [Clang][diagnostics] Improve the diagnostics for chained comparisons (PR #129285)

Amr Hesham via cfe-commits cfe-commits at lists.llvm.org
Fri Feb 28 11:09:52 PST 2025


================
@@ -85,7 +85,7 @@ void f(int x, int y, int z) {
   if ((a<y) != -1) {}// expected-warning {{comparison of constant -1 with boolean expression is always true}}
 
   if ((a<y) == z) {} // no warning
-  if (a>y<z)      {} // expected-error {{comparisons like 'X<=Y<=Z' don't have their mathematical meaning}}
+  if (a>y<z)      {} // expected-error {{comparisons like 'a > y < z' don't have their mathematical meaning}}
----------------
AmrDeveloper wrote:

Yes i think the word `like` should be removed here, but I am thinking should we prefer the previous diagnostics or the one with actual expression

https://github.com/llvm/llvm-project/pull/129285


More information about the cfe-commits mailing list