[clang] [clang-repl] Disable EmulatedTLS on Windows for interpreter executor (PR #127468)

Martin Storsjö via cfe-commits cfe-commits at lists.llvm.org
Fri Feb 28 01:57:55 PST 2025


================
@@ -597,6 +597,9 @@ llvm::Error Interpreter::CreateExecutor() {
     auto JTMB = createJITTargetMachineBuilder(TT);
     if (!JTMB)
       return JTMB.takeError();
+#if defined(_WIN32)
----------------
mstorsjo wrote:

I'm not sure what the common practice is for the JIT/interpreter side, but I would prefer to use a check in code, whether the target triple is windows, rather than using an ifdef. Most of clang is cross-compiling agnostic anyway. For the JIT that's obviously not the case, but by not using ifdefs, you get the code compile tested in all builds, not only the windows ones.

https://github.com/llvm/llvm-project/pull/127468


More information about the cfe-commits mailing list