[clang] [NFC][analyzer] Simplify ownership of checker objects (PR #128887)

[Donát Nagy via cfe-commits]

================
@@ -201,24 +199,24 @@ class CheckerManager {
   template <typename CHECKER, typename... AT>
   CHECKER *registerChecker(AT &&... Args) {
     CheckerTag tag = getTag<CHECKER>();
-    CheckerRef &ref = CheckerTags[tag];
-    assert(!ref && "Checker already registered, use getChecker!");
-
-    CHECKER *checker = new CHECKER(std::forward<AT>(Args)...);
-    checker->Name = CurrentCheckerName;
-    CheckerDtors.push_back(CheckerDtor(checker, destruct<CHECKER>));
----------------
NagyDonat wrote:

Thanks for spotting this, my change indeed left `destruct` as dead code. I'm removing it in https://github.com/llvm/llvm-project/pull/128887/commits/9f4a8a8d3bf50d29e7bd67f5a9b4142bbe068abc

https://github.com/llvm/llvm-project/pull/128887