[clang] [NFC][analyzer] Simplify ownership of checker objects (PR #128887)

[Donát Nagy via cfe-commits]

================
@@ -185,13 +185,11 @@ class CheckerManager {
                                        StringRef OptionName,
                                        StringRef ExpectedValueDesc) const;
 
-  using CheckerRef = CheckerBase *;
   using CheckerTag = const void *;
-  using CheckerDtor = CheckerFn<void ()>;
 
-//===----------------------------------------------------------------------===//
-// Checker registration.
-//===----------------------------------------------------------------------===//
+  //===----------------------------------------------------------------------===//
+  // Checker registration.
+  //===----------------------------------------------------------------------===//
----------------
NagyDonat wrote:

I think I'll indent this comment and the other analogous headings to satisfy `git-clang-format`. I don't want to remove them because I feel that visible headers like this are _very_ useful when I want to quickly understand the architecture of a large cumbersome class.

https://github.com/llvm/llvm-project/pull/128887