[clang] [HLSL] error on out of bounds vector accesses (PR #128952)

[via cfe-commits]

================
@@ -14017,6 +14017,24 @@ void Sema::CheckCastAlign(Expr *Op, QualType T, SourceRange TRange) {
     << TRange << Op->getSourceRange();
 }
 
+void Sema::CheckVectorAccess(const Expr *BaseExpr, const Expr *IndexExpr) {
+  const VectorType *VTy = BaseExpr->getType()->getAs<VectorType>();
+  if (!VTy)
+    return;
+
+  Expr::EvalResult Result;
+  if (!IndexExpr->EvaluateAsInt(Result, Context, Expr::SE_AllowSideEffects))
+    return;
+
+  unsigned DiagID = getLangOpts().HLSL ? diag::err_vector_index_out_of_range
+                                       : diag::warn_vector_index_out_of_range;
----------------
joaosaffran wrote:

Not sure if this warning makes sense for other languages, some languages allow negative vector indexing, for example. Just my opinion thought, feel free to ignore if disagree.

https://github.com/llvm/llvm-project/pull/128952