[clang] [MS][clang] Add support for vector deleting destructors (PR #126240)

Reid Kleckner via cfe-commits cfe-commits at lists.llvm.org
Wed Feb 26 15:14:11 PST 2025


================
@@ -2657,7 +2657,10 @@ class VFTableBuilder {
       MethodVFTableLocation Loc(MI.VBTableIndex, WhichVFPtr.getVBaseWithVPtr(),
                                 WhichVFPtr.NonVirtualOffset, MI.VFTableIndex);
       if (const CXXDestructorDecl *DD = dyn_cast<CXXDestructorDecl>(MD)) {
-        MethodVFTableLocations[GlobalDecl(DD, Dtor_Deleting)] = Loc;
+        if (!Context.getTargetInfo().getCXXABI().isMicrosoft())
----------------
rnk wrote:

Code golf nit: Rather than duplicating the densemap insertion you can select the appropriate dtor type and construct the GlobalDecl with a dtor type variable.

https://github.com/llvm/llvm-project/pull/126240


More information about the cfe-commits mailing list