[clang] [llvm] [llvm:ir] Add support for constant data exceeding 4GiB (PR #126481)

[Eli Friedman via cfe-commits]

================
@@ -617,15 +617,15 @@ class ConstantDataSequential : public ConstantData {
 
   /// If this is a sequential container of integers (of any size), return the
   /// specified element in the low bits of a uint64_t.
-  uint64_t getElementAsInteger(unsigned i) const;
+  uint64_t getElementAsInteger(uint64_t i) const;
 
   /// If this is a sequential container of integers (of any size), return the
   /// specified element as an APInt.
   APInt getElementAsAPInt(unsigned i) const;
----------------
efriedma-quic wrote:

For consistency, I'm going to ask you change the rest of the getElementAs*.  (I agree this change shouldn't grow indefinitely, so I'm not going to request anything beyond that.  But having half the accessors use "unsigned" and the other half use "uint64_t" is confusing.)

https://github.com/llvm/llvm-project/pull/126481