[clang] [clang] Improve diagnostics for vector builtins (PR #125673)

[Fraser Cormack via cfe-commits]

================
@@ -2266,8 +2266,10 @@ bool SemaHLSL::CheckBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) {
     if (CheckVectorElementCallArgs(&SemaRef, TheCall))
       return true;
     if (SemaRef.BuiltinElementwiseTernaryMath(
-            TheCall, /*CheckForFloatArgs*/
-            TheCall->getArg(0)->getType()->hasFloatingRepresentation()))
+            TheCall, /*ArgTyRestr*/
----------------
frasercrmck wrote:

Thanks, good spot. Also applied to the other instance in this file. I half wish clang-tidy would point these out (at least, it didn't for me).

https://github.com/llvm/llvm-project/pull/125673