[clang] [alpha.webkit.NoUnretainedMemberChecker] Add a new WebKit checker for unretained member variables and ivars. (PR #128641)
via cfe-commits
cfe-commits at lists.llvm.org
Mon Feb 24 23:09:28 PST 2025
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff b335d5a8303250cb49901ecae7570adf61abbd3c a4cd301d6176a8ee3441d0c74f6d2c4e32a50cdd --extensions cpp -- clang/lib/StaticAnalyzer/Checkers/WebKit/RawPtrRefMemberChecker.cpp
``````````
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/clang/lib/StaticAnalyzer/Checkers/WebKit/RawPtrRefMemberChecker.cpp b/clang/lib/StaticAnalyzer/Checkers/WebKit/RawPtrRefMemberChecker.cpp
index 0e0fd95e1d..593e6e3663 100644
--- a/clang/lib/StaticAnalyzer/Checkers/WebKit/RawPtrRefMemberChecker.cpp
+++ b/clang/lib/StaticAnalyzer/Checkers/WebKit/RawPtrRefMemberChecker.cpp
@@ -100,7 +100,7 @@ public:
reportBug(Member, MemberType, MemberCXXRD, RD);
} else {
std::optional<bool> IsCompatible = isPtrCompatible(QT, nullptr);
- auto* PointeeType = MemberType->getPointeeType().getTypePtrOrNull();
+ auto *PointeeType = MemberType->getPointeeType().getTypePtrOrNull();
if (IsCompatible && *IsCompatible) {
auto *Desugared = PointeeType->getUnqualifiedDesugaredType();
if (auto *ObjCType = dyn_cast_or_null<ObjCInterfaceType>(Desugared))
@@ -205,12 +205,11 @@ public:
}
enum class PrintDeclKind { Pointee, Pointer };
- virtual PrintDeclKind printPointer(llvm::raw_svector_ostream& Os,
- const Type *T) const {
+ virtual PrintDeclKind printPointer(llvm::raw_svector_ostream &Os,
+ const Type *T) const {
T = T->getUnqualifiedDesugaredType();
bool IsPtr = isa<PointerType>(T) || isa<ObjCObjectPointerType>(T);
- Os << (IsPtr ? "raw pointer" : "reference") << " to "
- << typeName() << " ";
+ Os << (IsPtr ? "raw pointer" : "reference") << " to " << typeName() << " ";
return PrintDeclKind::Pointee;
}
};
@@ -286,7 +285,7 @@ public:
return "member variables must be a RetainPtr";
}
- PrintDeclKind printPointer(llvm::raw_svector_ostream& Os,
+ PrintDeclKind printPointer(llvm::raw_svector_ostream &Os,
const Type *T) const final {
if (!isa<ObjCObjectPointerType>(T) && T->getAs<TypedefType>()) {
Os << typeName() << " ";
@@ -319,7 +318,6 @@ void ento::registerNoUnretainedMemberChecker(CheckerManager &Mgr) {
Mgr.registerChecker<NoUnretainedMemberChecker>();
}
-bool ento::shouldRegisterNoUnretainedMemberChecker(
- const CheckerManager &Mgr) {
+bool ento::shouldRegisterNoUnretainedMemberChecker(const CheckerManager &Mgr) {
return true;
}
``````````
</details>
https://github.com/llvm/llvm-project/pull/128641
More information about the cfe-commits
mailing list