[clang] [analyzer] Clean up slightly the messed up ownership model of the analyzer (PR #128368)

[Balazs Benics via cfe-commits]

================
@@ -50,14 +46,11 @@ AnalysisManager::AnalysisManager(ASTContext &ASTCtx, Preprocessor &PP,
 
 AnalysisManager::~AnalysisManager() {
   FlushDiagnostics();
-  for (PathDiagnosticConsumer *Consumer : PathConsumers) {
-    delete Consumer;
-  }
 }
----------------
steakhal wrote:

```suggestion
AnalysisManager::~AnalysisManager() { FlushDiagnostics(); }
```

https://github.com/llvm/llvm-project/pull/128368