[libclc] [libclc] Move fma to the CLC library (PR #126052)

Fraser Cormack via cfe-commits cfe-commits at lists.llvm.org
Mon Feb 24 01:56:43 PST 2025


frasercrmck wrote:

> > FYI @rjodinchr this breaks downstream clspv testing.
> > ```
> > # | declare !kernel_arg_name !7 float @llvm.fma.f32(float, float, float) #2
> > # | Unsupported llvm intrinsic
> > # | UNREACHABLE executed at /clspv/lib/SPIRVProducerPass.cpp:2390!
> > ```
> > 
> > 
> >     
> >       
> >     
> > 
> >       
> >     
> > 
> >     
> >   
> > I was wondering if clspv should be translating `llvm.fma` to `OpExtInst fma` as `llvm-spirv` does.
> 
> I guess it would just be a question of adding `llvm.fma` here: https://github.com/google/clspv/blob/0878df110af85e84d0c336e6571767278ad5eec8/lib/Builtins.cpp#L703

With that change, `check-spirv` does indeed pass. Does that mean this PR is good to go, do you think?

https://github.com/llvm/llvm-project/pull/126052


More information about the cfe-commits mailing list