[clang] [clang-offload-packager] Avoid repeated hash lookups (NFC) (PR #128297)

Kazu Hirata via cfe-commits cfe-commits at lists.llvm.org
Fri Feb 21 23:54:15 PST 2025


https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/128297

None

>From ef4aa1dfadb97132b77a9022abc3e5095c24763c Mon Sep 17 00:00:00 2001
From: Kazu Hirata <kazu at google.com>
Date: Fri, 21 Feb 2025 11:22:07 -0800
Subject: [PATCH] [clang-offload-packager] Avoid repeated hash lookups (NFC)

---
 clang/tools/clang-offload-packager/ClangOffloadPackager.cpp | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/clang/tools/clang-offload-packager/ClangOffloadPackager.cpp b/clang/tools/clang-offload-packager/ClangOffloadPackager.cpp
index 49cb0d70f492b..8cd9691c30ada 100644
--- a/clang/tools/clang-offload-packager/ClangOffloadPackager.cpp
+++ b/clang/tools/clang-offload-packager/ClangOffloadPackager.cpp
@@ -198,12 +198,12 @@ static Error unbundleImages() {
               Args["file"], Members, SymtabWritingMode::NormalSymtab,
               Archive::getDefaultKind(), true, false, nullptr))
         return E;
-    } else if (Args.count("file")) {
+    } else if (auto It = Args.find("file"); It != Args.end()) {
       if (Extracted.size() > 1)
         WithColor::warning(errs(), PackagerExecutable)
-            << "Multiple inputs match to a single file, '" << Args["file"]
+            << "Multiple inputs match to a single file, '" << It->second
             << "'\n";
-      if (Error E = writeFile(Args["file"], Extracted.back()->getImage()))
+      if (Error E = writeFile(It->second, Extracted.back()->getImage()))
         return E;
     } else {
       uint64_t Idx = 0;



More information about the cfe-commits mailing list