[clang] [HLSL] add parentheses in assertion to eliminate -Wparentheses warning (PR #128246)

via cfe-commits cfe-commits at lists.llvm.org
Fri Feb 21 15:03:07 PST 2025


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-clang

Author: Oleksandr T. (a-tarasyuk)

<details>
<summary>Changes</summary>

Fixes #<!-- -->128210 

---
Full diff: https://github.com/llvm/llvm-project/pull/128246.diff


1 Files Affected:

- (modified) clang/lib/CodeGen/HLSLBufferLayoutBuilder.cpp (+3-3) 


``````````diff
diff --git a/clang/lib/CodeGen/HLSLBufferLayoutBuilder.cpp b/clang/lib/CodeGen/HLSLBufferLayoutBuilder.cpp
index 1ae00023ab2bc..97262b76c0164 100644
--- a/clang/lib/CodeGen/HLSLBufferLayoutBuilder.cpp
+++ b/clang/lib/CodeGen/HLSLBufferLayoutBuilder.cpp
@@ -89,9 +89,9 @@ llvm::TargetExtType *HLSLBufferLayoutBuilder::createLayoutType(
     RecordTypes.pop_back();
 
     for (const auto *FD : RT->getDecl()->fields()) {
-      assert(!Packoffsets || Index < Packoffsets->size() &&
-                                 "number of elements in layout struct does not "
-                                 "match number of packoffset annotations");
+      assert((!Packoffsets || Index < Packoffsets->size()) &&
+             "number of elements in layout struct does not "
+             "match number of packoffset annotations");
 
       if (!layoutField(FD, EndOffset, Layout, LayoutElements,
                        Packoffsets ? (*Packoffsets)[Index] : -1))

``````````

</details>


https://github.com/llvm/llvm-project/pull/128246


More information about the cfe-commits mailing list