[clang] [HLSL][Sema] Fix Struct Size Calculation containing 16/32 bit scalars (PR #128086)

Helena Kotas via cfe-commits cfe-commits at lists.llvm.org
Fri Feb 21 09:29:22 PST 2025


================
@@ -172,6 +172,27 @@ Decl *SemaHLSL::ActOnStartBuffer(Scope *BufferScope, bool CBuffer,
   return Result;
 }
 
+static unsigned calculateLegacyCbufferFieldAlign(const ASTContext &Context,
+                                                 QualType T) {
+  // Aggregate types are always aligned to new buffer rows
+  if (T->isAggregateType())
----------------
hekota wrote:

According to documentation `isAggregateType` is `false` if the class has a base class. It would be better to explicitly check `isArrayType() || isStructureType()`.

https://github.com/llvm/llvm-project/pull/128086


More information about the cfe-commits mailing list