[clang] Reapply "[Analyzer][CFG] Correctly handle rebuilt default arg and default init expression" (PR #127338)

[Jan Voung via cfe-commits]

jvoung wrote:

> > In case others notice similar in ClangTidy (`bugprone-unchecked-optional-access`), we are seeing crashes after this change #128068
> > I'm not yet sure the best fix.
> 
> Can you try to revert this change to see if the crash issue can be fixed? It looks like I missing some changes in dataflow.

Sure! I tried a revert and I think the crash goes away.

Before: https://buildkite.com/llvm-project/github-pull-requests/builds/149145#01952526-e921-4076-a03c-de90c69c56e5
After: https://buildkite.com/llvm-project/github-pull-requests/builds/149456#01952902-996f-474d-910e-a2bd8cec9e11
 (well at least the Windows builder has finished)

https://github.com/llvm/llvm-project/pull/127338