[clang] [NFC][hlsl][Sema] Simplify CBuffer Legacy Size Calculation Control Flow (PR #127921)

[LLVM Continuous Integration via cfe-commits]

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `lldb-remote-linux-ubuntu` running on `as-builder-9` while building `clang` at step 16 "test-check-lldb-api".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/195/builds/5171

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 16 (test-check-lldb-api) failure: Test just built components: check-lldb-api completed (failure)
...
PASS: lldb-api :: types/TestCharTypeExpr.py (1223 of 1232)
PASS: lldb-api :: types/TestIntegerType.py (1224 of 1232)
PASS: lldb-api :: types/TestRecursiveTypes.py (1225 of 1232)
PASS: lldb-api :: types/TestIntegerTypeExpr.py (1226 of 1232)
PASS: lldb-api :: python_api/watchpoint/watchlocation/TestTargetWatchAddress.py (1227 of 1232)
PASS: lldb-api :: types/TestShortType.py (1228 of 1232)
PASS: lldb-api :: types/TestLongTypes.py (1229 of 1232)
PASS: lldb-api :: types/TestShortTypeExpr.py (1230 of 1232)
PASS: lldb-api :: types/TestLongTypesExpr.py (1231 of 1232)
TIMEOUT: lldb-api :: python_api/process/cancel_attach/TestCancelAttach.py (1232 of 1232)
******************** TEST 'lldb-api :: python_api/process/cancel_attach/TestCancelAttach.py' FAILED ********************
Script:
--
/usr/bin/python3.12 /home/buildbot/worker/as-builder-9/lldb-remote-linux-ubuntu/llvm-project/lldb/test/API/dotest.py -u CXXFLAGS -u CFLAGS --env LLVM_LIBS_DIR=/home/buildbot/worker/as-builder-9/lldb-remote-linux-ubuntu/build/./lib --env LLVM_INCLUDE_DIR=/home/buildbot/worker/as-builder-9/lldb-remote-linux-ubuntu/build/include --env LLVM_TOOLS_DIR=/home/buildbot/worker/as-builder-9/lldb-remote-linux-ubuntu/build/./bin --libcxx-include-dir /home/buildbot/worker/as-builder-9/lldb-remote-linux-ubuntu/build/include/c++/v1 --libcxx-include-target-dir /home/buildbot/worker/as-builder-9/lldb-remote-linux-ubuntu/build/include/aarch64-unknown-linux-gnu/c++/v1 --libcxx-library-dir /home/buildbot/worker/as-builder-9/lldb-remote-linux-ubuntu/build/./lib/aarch64-unknown-linux-gnu --arch aarch64 --build-dir /home/buildbot/worker/as-builder-9/lldb-remote-linux-ubuntu/build/lldb-test-build.noindex --lldb-module-cache-dir /home/buildbot/worker/as-builder-9/lldb-remote-linux-ubuntu/build/lldb-test-build.noindex/module-cache-lldb/lldb-api --clang-module-cache-dir /home/buildbot/worker/as-builder-9/lldb-remote-linux-ubuntu/build/lldb-test-build.noindex/module-cache-clang/lldb-api --executable /home/buildbot/worker/as-builder-9/lldb-remote-linux-ubuntu/build/./bin/lldb --compiler /home/buildbot/worker/as-builder-9/lldb-remote-linux-ubuntu/build/bin/clang --dsymutil /home/buildbot/worker/as-builder-9/lldb-remote-linux-ubuntu/build/./bin/dsymutil --make /usr/bin/gmake --llvm-tools-dir /home/buildbot/worker/as-builder-9/lldb-remote-linux-ubuntu/build/./bin --lldb-obj-root /home/buildbot/worker/as-builder-9/lldb-remote-linux-ubuntu/build/tools/lldb --lldb-libs-dir /home/buildbot/worker/as-builder-9/lldb-remote-linux-ubuntu/build/./lib --platform-url connect://jetson-agx-2198.lab.llvm.org:1234 --platform-working-dir /home/ubuntu/lldb-tests --sysroot /mnt/fs/jetson-agx-ubuntu --env ARCH_CFLAGS=-mcpu=cortex-a78 --platform-name remote-linux --skip-category=lldb-server /home/buildbot/worker/as-builder-9/lldb-remote-linux-ubuntu/llvm-project/lldb/test/API/python_api/process/cancel_attach -p TestCancelAttach.py
--
Exit Code: -9
Timeout: Reached timeout of 600 seconds

Command Output (stdout):
--
lldb version 21.0.0git (https://github.com/llvm/llvm-project.git revision 5bf37484c6b0fc38a63465a36890a11494e4fc07)
  clang revision 5bf37484c6b0fc38a63465a36890a11494e4fc07
  llvm revision 5bf37484c6b0fc38a63465a36890a11494e4fc07

--
Command Output (stderr):
--
WARNING:root:Custom libc++ is not supported for remote runs: ignoring --libcxx arguments
FAIL: LLDB (/home/buildbot/worker/as-builder-9/lldb-remote-linux-ubuntu/build/bin/clang-aarch64) :: test_scripted_implementation (TestCancelAttach.AttachCancelTestCase.test_scripted_implementation)

--

********************
Slowest Tests:
--------------------------------------------------------------------------
600.04s: lldb-api :: python_api/process/cancel_attach/TestCancelAttach.py
180.97s: lldb-api :: commands/command/script_alias/TestCommandScriptAlias.py
70.46s: lldb-api :: commands/process/attach/TestProcessAttach.py
40.38s: lldb-api :: functionalities/data-formatter/data-formatter-stl/libcxx-simulators/string/TestDataFormatterLibcxxStringSimulator.py
35.19s: lldb-api :: functionalities/completion/TestCompletion.py
35.05s: lldb-api :: functionalities/single-thread-step/TestSingleThreadStepTimeout.py
26.12s: lldb-api :: python_api/watchpoint/watchlocation/TestTargetWatchAddress.py
20.69s: lldb-api :: functionalities/gdb_remote_client/TestPlatformClient.py
20.57s: lldb-api :: commands/statistics/basic/TestStats.py
18.87s: lldb-api :: functionalities/thread/state/TestThreadStates.py
18.37s: lldb-api :: commands/dwim-print/TestDWIMPrint.py
14.82s: lldb-api :: functionalities/data-formatter/data-formatter-stl/generic/set/TestDataFormatterGenericSet.py
14.69s: lldb-api :: commands/expression/expr-in-syscall/TestExpressionInSyscall.py
14.45s: lldb-api :: python_api/find_in_memory/TestFindRangesInMemory.py

```

</details>

https://github.com/llvm/llvm-project/pull/127921