[clang] [MS][clang] Add support for vector deleting destructors (PR #126240)

Mariya Podchishchaeva via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 20 08:54:02 PST 2025


================
@@ -448,7 +453,8 @@ class ItaniumCXXABI : public CodeGen::CGCXXABI {
        if (!IsInlined)
          continue;
 
-       StringRef Name = CGM.getMangledName(VtableComponent.getGlobalDecl());
+       StringRef Name =
+           CGM.getMangledName(VtableComponent.getGlobalDecl(false));
----------------
Fznamznon wrote:

> Perhaps it should be a method of VTableContextBase

I liked the idea at first, but `getGlobalDecl` also requires to know Kind and FunctionDecl of a particular VTableComponent which makes it require two parameters as a method of `VTableContextBase`. If that is ok, I would prefer to add the comment with ParamName instead.


https://github.com/llvm/llvm-project/pull/126240


More information about the cfe-commits mailing list