[clang] [clang] Added warn-assignment-bool-context (PR #115234)

[Erich Keane via cfe-commits]

================
@@ -8477,6 +8477,9 @@ def err_incomplete_object_call : Error<
 def warn_condition_is_assignment : Warning<"using the result of an "
   "assignment as a condition without parentheses">,
   InGroup<Parentheses>;
+def warn_assignment_bool_context : Warning<"suggest parentheses around assignment used as truth value">,
----------------
erichkeane wrote:

I realize this is the C diagnostic text, but I'm still not a huge fan.  The text in `warn_condition_is_idiomatic_assignment` is pretty close to what we want, right?  Perhaps we should use that?  Also, emitting `note_condition_assign_silence` might be sensible.

https://github.com/llvm/llvm-project/pull/115234