[clang] [clang] Added warn-assignment-bool-context (PR #115234)

[Erich Keane via cfe-commits]

================
@@ -687,6 +687,48 @@ void Sema::diagnoseZeroToNullptrConversion(CastKind Kind, const Expr *E) {
       << FixItHint::CreateReplacement(E->getSourceRange(), "nullptr");
 }
 
+void Sema::DiagnoseAssignmentBoolContext(Expr *E, QualType Ty) {
+  // Use copy to not alter original expression.
----------------
erichkeane wrote:

This is unnecessary.  You don't use the original value of `E` anywhere else below, so there isn't a good reason to  not just use the parameter.

https://github.com/llvm/llvm-project/pull/115234