[clang] [CIR] Upstream simple function bodies (PR #127674)

David Olsen via cfe-commits cfe-commits at lists.llvm.org
Wed Feb 19 11:27:52 PST 2025


================
@@ -224,3 +225,19 @@ mlir::Type CIRGenTypes::convertType(QualType type) {
   typeCache[ty] = resultType;
   return resultType;
 }
+
+mlir::Type CIRGenTypes::convertTypeForMem(clang::QualType qualType,
+                                          bool forBitField) {
+  assert(!qualType->isConstantMatrixType() && "Matrix types NYI");
+
+  mlir::Type convertedType = convertType(qualType);
----------------
dkolsen-pgi wrote:

`CIRGenTypes::convertTypeForMem` in the incubator doesn't have any special handling for `bool`, despite the comment on the declaration specifically pointing to `bool` as a type that needs special treatment.  The implementation here is an exact copy of what is in the incubator.  I created https://github.com/llvm/clangir/issues/1371 in the incubator project to sort this out.


https://github.com/llvm/llvm-project/pull/127674


More information about the cfe-commits mailing list