[clang] [Clang] add -Wshift-bool warning to handle shifting of bool (PR #127336)

Oleksandr T. via cfe-commits cfe-commits at lists.llvm.org
Tue Feb 18 04:19:30 PST 2025


================
@@ -11246,6 +11246,12 @@ static void DiagnoseBadShiftValues(Sema& S, ExprResult &LHS, ExprResult &RHS,
   if (S.getLangOpts().OpenCL)
     return;
 
+  if (LHS.get()->IgnoreParenImpCasts()->getType()->isBooleanType()) {
+    S.Diag(Loc, diag::warn_shift_bool)
+        << (Opc == BO_Shr) /*left|right*/ << LHS.get()->getSourceRange();
----------------
a-tarasyuk wrote:

@Fznamznon do you mean omitting the handling of the right shift? I suppose both `<<` and `>>` convert the type to `int`., so handling both seem appropriate. Or does it not?

https://github.com/llvm/llvm-project/pull/127336


More information about the cfe-commits mailing list