[libclc] [libclc] Suppress data-layout warnings during linking (PR #127532)

Fraser Cormack via cfe-commits cfe-commits at lists.llvm.org
Tue Feb 18 01:34:51 PST 2025


================
@@ -1,8 +1,4 @@
-#if __clang_major__ >= 7
-target datalayout = "e-p:64:64-p1:64:64-p2:32:32-p3:32:32-p4:64:64-p5:32:32-p6:32:32-i64:64-v16:16-v24:32-v32:32-v48:64-v96:128-v192:256-v256:256-v512:512-v1024:1024-v2048:2048-n32:64-S32-A5"
-#else
-target datalayout = "e-p:32:32-p1:64:64-p2:64:64-p3:32:32-p4:64:64-p5:32:32-i64:64-v16:16-v24:32-v32:32-v48:64-v96:128-v192:256-v256:256-v512:512-v1024:1024-v2048:2048-n32:64"
-#endif
+target datalayout = "e-p:64:64-p1:64:64-p2:32:32-p3:32:32-p4:64:64-p5:32:32-p6:32:32-p7:160:256:256:32-p8:128:128-p9:192:256:256:32-i64:64-v16:16-v24:32-v32:32-v48:64-v96:128-v192:256-v256:256-v512:512-v1024:1024-v2048:2048-n32:64-S32-A5-G1-ni:7:8:9"
----------------
frasercrmck wrote:

Hah, yeah, true. Though I think there'll always be a need for IR - at least, I'm not sure we should ban it outright. I don't think I'll find the time to convert these AMDGPU files to OpenCL C any time soon.

So if scrubbing data layouts works in principle I'd lean towards going for it, at least in the short/medium term. It's not a great look that these warnings are coming out of libclc.

That said, just grouping the IR files together at the start of the link line eliminates the bulk of warnings so if you want to keep the data layouts in, we're also in a better position than before this PR.

https://github.com/llvm/llvm-project/pull/127532


More information about the cfe-commits mailing list