[clang-tools-extra] 0b719d3 - [clangd] Enable parsing of forwarding functions in the preamble by default (#127359)

via cfe-commits cfe-commits at lists.llvm.org
Mon Feb 17 21:59:49 PST 2025


Author: Nathan Ridge
Date: 2025-02-18T00:59:45-05:00
New Revision: 0b719d3d63100c6af66b015f796ab74d3d218107

URL: https://github.com/llvm/llvm-project/commit/0b719d3d63100c6af66b015f796ab74d3d218107
DIFF: https://github.com/llvm/llvm-project/commit/0b719d3d63100c6af66b015f796ab74d3d218107.diff

LOG: [clangd] Enable parsing of forwarding functions in the preamble by default (#127359)

Fixes https://github.com/clangd/clangd/issues/2324

Added: 
    

Modified: 
    clang-tools-extra/clangd/ClangdServer.h
    clang-tools-extra/clangd/Compiler.h

Removed: 
    


################################################################################
diff  --git a/clang-tools-extra/clangd/ClangdServer.h b/clang-tools-extra/clangd/ClangdServer.h
index e030bf04122d5..1e612e2ba618e 100644
--- a/clang-tools-extra/clangd/ClangdServer.h
+++ b/clang-tools-extra/clangd/ClangdServer.h
@@ -184,7 +184,7 @@ class ClangdServer {
     bool UseDirtyHeaders = false;
 
     // If true, parse emplace-like functions in the preamble.
-    bool PreambleParseForwardingFunctions = false;
+    bool PreambleParseForwardingFunctions = true;
 
     /// Whether include fixer insertions for Objective-C code should use #import
     /// instead of #include.
@@ -501,7 +501,7 @@ class ClangdServer {
   // Whether the client supports folding only complete lines.
   bool LineFoldingOnly = false;
 
-  bool PreambleParseForwardingFunctions = false;
+  bool PreambleParseForwardingFunctions = true;
 
   bool ImportInsertions = false;
 

diff  --git a/clang-tools-extra/clangd/Compiler.h b/clang-tools-extra/clangd/Compiler.h
index 4e68da7610ca2..e513e4c40794a 100644
--- a/clang-tools-extra/clangd/Compiler.h
+++ b/clang-tools-extra/clangd/Compiler.h
@@ -40,7 +40,7 @@ class IgnoreDiagnostics : public DiagnosticConsumer {
 
 // Options to run clang e.g. when parsing AST.
 struct ParseOptions {
-  bool PreambleParseForwardingFunctions = false;
+  bool PreambleParseForwardingFunctions = true;
 
   bool ImportInsertions = false;
 };


        


More information about the cfe-commits mailing list