[libclc] [libclc] Suppress data-layout warnings during linking (PR #127532)

Matt Arsenault via cfe-commits cfe-commits at lists.llvm.org
Mon Feb 17 20:34:15 PST 2025


================
@@ -1,8 +1,4 @@
-#if __clang_major__ >= 7
-target datalayout = "e-p:64:64-p1:64:64-p2:32:32-p3:32:32-p4:64:64-p5:32:32-p6:32:32-i64:64-v16:16-v24:32-v32:32-v48:64-v96:128-v192:256-v256:256-v512:512-v1024:1024-v2048:2048-n32:64-S32-A5"
-#else
-target datalayout = "e-p:32:32-p1:64:64-p2:64:64-p3:32:32-p4:64:64-p5:32:32-i64:64-v16:16-v24:32-v32:32-v48:64-v96:128-v192:256-v256:256-v512:512-v1024:1024-v2048:2048-n32:64"
-#endif
+target datalayout = "e-p:64:64-p1:64:64-p2:32:32-p3:32:32-p4:64:64-p5:32:32-p6:32:32-p7:160:256:256:32-p8:128:128-p9:192:256:256:32-i64:64-v16:16-v24:32-v32:32-v48:64-v96:128-v192:256-v256:256-v512:512-v1024:1024-v2048:2048-n32:64-S32-A5-G1-ni:7:8:9"
----------------
arsenm wrote:

It would work in this situation, but technically this is a toothpaste-out-of-the-tube situation.

But really we should stop using iR for these. I don't know why these specifically are in the first place, but I'm guessing we didn't have complete builtin coverage in clang for atomics in the past. These should all be implementable with the atomic builtins these days 

https://github.com/llvm/llvm-project/pull/127532


More information about the cfe-commits mailing list