[clang] [HLSL] Implement the 'and' HLSL function (PR #127098)

Farzon Lotfi via cfe-commits cfe-commits at lists.llvm.org
Mon Feb 17 13:20:50 PST 2025


================
@@ -2245,6 +2245,36 @@ bool SemaHLSL::CheckBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) {
 
     break;
   }
+  case Builtin::BI__builtin_hlsl_and: {
+    if (SemaRef.checkArgCount(TheCall, 2))
+      return true;
+    if (CheckVectorElementCallArgs(&SemaRef, TheCall))
+      return true;
+
+    // CheckVectorElementCallArgs(...) guarantees both args are the same type.
+    assert(TheCall->getArg(0)->getType() == TheCall->getArg(1)->getType() &&
+           "Both args must be of the same type");
+
+    // check that the arguments are bools or, if vectors,
+    // vectors of bools
+    QualType ArgTy = TheCall->getArg(0)->getType();
+    if (const auto *VecTy = ArgTy->getAs<VectorType>()) {
+      ArgTy = VecTy->getElementType();
+    }
+    if (!getASTContext().hasSameUnqualifiedType(ArgTy,
----------------
farzonl wrote:

Anyways to move forward on this PR since `and` is just a `bool` scalar or vector arg  and since we agree on using the `err_typecheck_expect_scalar_or_vector`  diagnostic  if @Icohedron switches to using `CheckScalarOrVector` instead of doing the `SemaRef.Diag` directly I'll sign off on this PR.

https://github.com/llvm/llvm-project/pull/127098


More information about the cfe-commits mailing list