[clang-tools-extra] [clang-tidy] Check for `-ignore-insert-conflict` support before using it in `apply_fixes` in `run-clang-tidy.py` (PR #127066)

[Carlos Galvez via cfe-commits]

Vicente Mataix =?utf-8?q?Ferrándiz?= <vmataix at altair.com>,
Vicente Mataix =?utf-8?q?Ferrándiz?= <vmataix at altair.com>,
Vicente Mataix =?utf-8?q?Ferrándiz?= <vmataix at altair.com>,
Vicente Mataix =?utf-8?q?Ferrándiz?= <vmataix at altair.com>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/127066 at github.com>


carlosgalvezp wrote:

>  should have delivered a run-clang-tidy.py that is appropriate for that version.

It should, but does it? A typical installation comes from installing the Ubuntu packages, do they include `run-clang-tidy.py` at all?

If not, then I don't think `run-clang-tidy.py` should have the expectations of backwards compatibility and so on that we have for the more "public" deliveries. In that case, I agree with @whisperity that you should use a matching version.

You are not in control of the Clang/clang-tidy packages, but what about `run-clang-tidy.py`, @loumalouomega ? Can you downgrade that instead, to a version that matches the Clang/clang-tidy installation you have? I mean you should be able to clone this repo and checkout a compatible version, right? Since you already can clone the repo and put up a PR.

https://github.com/llvm/llvm-project/pull/127066